ci: install slackify globally to avoid conflicts with pnpm #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmvilas
requested review from
derberg,
KhudaDad414 and
asyncapi-bot-eve
as code owners
derberg
changed the title
|
/rtm |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some repos like studio and glee are using pnpm. Pnpm uses a syntax in the package.json file that npm doesn't recognize as valid, namely
"package-name": "workspace:*". The Slackify action in this repo tries to install a dependency on the repo using npm and that causes an error: https://github.com/asyncapi/glee/actions/runs/11571817568/job/32210507703.To avoid this problem, I'd advocate for simply installing the dependency globally instead.